Repository navigation
feat: board add accepts probe-rs selector strings - #10
Merged
Merged
Conversation
added 16 commits
June 29, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paavo-cli board add --probenow accepts probe-rs selector strings directly — either a bare token (1fc9:0143-0:SERIAL) or a full pastedprobe-rs listline — instead of the brittlesplit(':')that mis-parsed probe-rs's-IFACEsuffix and truncated colon-bearing serials. Selectors are parsed and validated at registration (fail fast, not hours later atprobe_attach) via a canonicalProbeSelector::parseinpaavo-proto; the USB interface index is preserved and threaded to probe-rs at attach; and VID/PID are stored canonicalized (lowercase 4-hex) by both ingestion paths.Feature
ProbeSelector.interface;ProbeSelector::parse(token or list line, probe-rs grammar incl. colon-serials),validate,canonicalize; typedProbeSelectorParseError.board addparses via proto and fails locally before any network call; reworded--probehelp.POST /boardscanonicalizes + validates (400on bad hex);boards.tomlseeds canonicalized + validated at startup.interfaceat probe attach (e.g. FTDI multi-interface).Deployment fixes (contrib)
Real landmines hit bringing up a fresh lab box:
CARGO_HOME/RUSTUP_HOME/PATHto the state dir so the sandboxed daemon (ProtectHome=true) can actually build test crates.1fc9); group probes to thepaavoservice user; document an all-USB catch-all.boards.tomldescription; added an AGENTS.md landmine.Design docs
docs/superpowers/specs/2026-06-29-probe-selector-parsing-design.mddocs/superpowers/plans/2026-06-29-probe-selector-parsing.mdTest plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace— new proto parse/canonicalize unit tests, CLI fail-fast + end-to-end pasted-list-line round-trip, daemon400+ normalize-on-store tests,boards.tomlstartup validate/canonicalize testsPAAVO_HW=1): interface threading on a real MCX-A266 probe